Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins ci #40

Open
wants to merge 32 commits into
base: amd-develop
Choose a base branch
from
Open

Jenkins ci #40

wants to merge 32 commits into from

Conversation

illsilin
Copy link
Collaborator

This commit includes several changes:

  1. Re-enables the CI using MIOpen/CK Jenkins resources.
  2. Updates the Pytorch and ROCm versions.
  3. Updates the docker image, moving all necessary python packages into the docker.
  4. The performance results will now be written to our internal database.

@illsilin illsilin requested a review from carlushuang March 27, 2023 19:42
@illsilin illsilin requested a review from fsx950223 March 27, 2023 19:42

# Install packages for processing the performance results
RUN pip3 install --upgrade pip
RUN pip3 install sqlalchemy==1.4.46
Copy link

@fsx950223 fsx950223 Mar 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put pip instlal in a RUN command and install sympy recordtype parameterized einops jinja2 too.
Also add pined lint python package pip install ufmt==2.0.1 click==8.1.3 black==22.12.0 flake8==5.0.4.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go ahead and add any packages you need.

print_log_header 04_vit.log $hostname $GIT_BRANCH
HIP_VISIBLE_DEVICES=0 python3 benchmark_ait.py 2>&1 | tee -a 04_vit.log
# test 2 gcd
for BATCH_SIZE in 1 2 4 8 16 32 64 128 256
Copy link

@fsx950223 fsx950223 Mar 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there should be less batch sizes? Such as 1, 8, 32, 256

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll discuss the number of tests with Jing and Chao tomorrow. Right now, when we run our CI on jenkins nodes, we cannot count on more than 1 GPU being there, so everything got pretty slow, 5-6 hours. I would recommend cutting down the number of tests to 2-3 cases for each test type on a standard CI and maybe run one full set on a daily basis with develop branch.

@fsx950223
Copy link

fsx950223 commented Mar 28, 2023

Why the PR pull to amd-develop branch instead of merge_upstream

@illsilin
Copy link
Collaborator Author

Because this is CI for our repo, so we need it in our repo, not in FB one.

@fsx950223
Copy link

Thanks, I understand.

@illsilin
Copy link
Collaborator Author

Next time when we merge up from our repo to FB, we will omit the Jenkinsfile and just push the updated docker file and test scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants