Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permutation flag to python shape constructor #3826

Merged
merged 4 commits into from
Feb 19, 2025
Merged

Conversation

pfultz2
Copy link
Collaborator

@pfultz2 pfultz2 commented Feb 18, 2025

No description provided.

@pfultz2 pfultz2 requested a review from causten as a code owner February 18, 2025 18:14
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.35%. Comparing base (27a90b5) to head (55b0c6e).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3826   +/-   ##
========================================
  Coverage    92.35%   92.35%           
========================================
  Files          519      519           
  Lines        22311    22311           
========================================
  Hits         20606    20606           
  Misses        1705     1705           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
55b0c6
Rate old
bfc14e
Diff Compare
torchvision-resnet50 64 3,237.23 3,233.96 0.10%
torchvision-resnet50_fp16 64 6,874.33 6,874.33 0.00%
torchvision-densenet121 32 2,437.54 2,436.94 0.02%
torchvision-densenet121_fp16 32 4,186.43 4,181.18 0.13%
torchvision-inceptionv3 32 1,612.90 1,612.90 0.00%
torchvision-inceptionv3_fp16 32 2,680.07 2,677.82 0.08%
cadene-inceptionv4 16 750.12 750.47 -0.05%
cadene-resnext64x4 16 810.13 809.72 0.05%
slim-mobilenet 64 6,660.24 6,659.15 0.02%
slim-nasnetalarge 64 196.86 196.77 0.05%
slim-resnet50v2 64 3,432.15 3,430.42 0.05%
bert-mrpc-onnx 8 1,136.36 1,133.14 0.28%
bert-mrpc-tf 1 505.05 500.00 1.01%
pytorch-examples-wlang-gru 1 465.51 470.97 -1.16%
pytorch-examples-wlang-lstm 1 449.28 437.32 2.73%
torchvision-resnet50_1 1 793.65 793.65 0.00%
cadene-dpn92_1 1 431.86 430.36 0.35%
cadene-resnext101_1 1 389.11 389.11 0.00%
onnx-taau-downsample 1 371.14 371.31 -0.05%
dlrm-criteoterabyte 1 31.79 31.79 -0.01%
dlrm-criteoterabyte_fp16 1 51.05 51.06 -0.02%
agentmodel 1 8,780.48 8,658.38 1.41%
unet_fp16 2 58.26 58.36 -0.17%
resnet50v1_fp16 1 1,063.83 1,075.27 -1.06%
resnet50v1_int8 1 787.40 800.00 -1.57%
bert_base_cased_fp16 64 1,159.42 1,159.42 0.00%
bert_large_uncased_fp16 32 360.08 359.96 0.03%
bert_large_fp16 1 215.05 215.98 -0.43%
distilgpt2_fp16 16 2,188.78 2,188.78 0.00%
yolov5s 1 516.37 531.08 -2.77%
tinyllama 1 49.14 49.12 0.05%
vicuna-fastchat 1 43.62 43.55 0.17%
whisper-tiny-encoder 1 438.60 436.68 0.44%
whisper-tiny-decoder 1 448.43 448.43 0.00%

This build is OK for merge ✅

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

@TedThemistokleous TedThemistokleous added enhancement New feature or request roadmap Tasks to finish for a release simple small or simple changes labels Feb 19, 2025
Copy link
Collaborator

@TedThemistokleous TedThemistokleous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@causten causten merged commit 1aff1af into develop Feb 19, 2025
38 of 39 checks passed
@causten causten deleted the py-shape-perm branch February 19, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request roadmap Tasks to finish for a release simple small or simple changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants