Codegen integration #3415
Open
Codegen integration #3415
+935
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uped_conv_fwd_multiple_abd files from CK
…ished debugging AddKernels version - solver is now running
…Open as well as the corresponding command line argument (right padding is hardcoded for now). Was having memory access issues that are currently resolved due to hardcoding of block size/grid size - need to figure out how this calculation differs from CK. With this version both the solver and the gtest are running (with the codegen packages). Need to integrate standalone codegen build
arai713
requested review from
BrianHarrisonAMD,
junliume and
BradPepersAMD
as code owners
CAHEK7
suggested changes
Dec 1, 2024
src/solver/codegen_conv_hip_implicit_gemm_2d_grouped_fwd_xdlops.cpp
Outdated
Show resolved
Hide resolved
Comment on lines
280
to
289
| auto kernel = handle_.AddKernel("tmp", | ||
| "tmp", | ||
| "cg_main.cpp", | ||
| kernel_info.kernel_name, | ||
| kernel_info.l_wk, | ||
| kernel_info.g_wk, | ||
| kernel_info.comp_options, | ||
| 0, | ||
| src); | ||
|
|
There was a problem hiding this comment.
Usually you should add the kernels outside of this lambda and later just use added kernels.
Like here:
MIOpen/src/solver/softmax/softmax.cpp
Line 336 in 6c4a0b3
The list of added kernels passed through const std::vector<Kernel>& kernels into that lambda.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.