-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MultilabelSoftMarginLoss for small C #3451
base: develop
Are you sure you want to change the base?
Conversation
- use miopenLossReductionMode_t in driver,gtest instead of divisor - delete unused member in invoke_params - format miopen.h - add __restrict__ in kernel func
@CAHEK7 I cannot add you as a reviewer for this PR 😅 So I have tagged to send a notification to you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked only the kernel, the tests and solver code (partially). It looks good.
That's because I'm not a part of the team now. But I'm checking some code from time to time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please the latest develop branch and rerun the CI to see if it passes.
Unreduced:
fp32
fp16
bfp16
Reduced:
fp32
fp16
bfp16