Skip to content

Commit

Permalink
drm/amdkfd: Use a new capability bit for SRAM ECC
Browse files Browse the repository at this point in the history
Existing, buggy user mode breaks when SRAM ECC is correctly reported as
"enabled". To avoid breaking existing user mode, deprecate that bit and
leave it as 0. Define a new bit to report the actual SRAM ECC mode that
new, correct user mode can use in the future.

Fixes: 7ec177b ("drm/amdkfd: fix set kfd node ras properties value")
Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
  • Loading branch information
fxkamd committed Feb 26, 2021
1 parent 9b83380 commit 6a986c0
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/gpu/drm/amd/amdkfd/kfd_topology.h
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,14 @@
#define HSA_DBG_TRAP_DEBUG_WATCH_MASK_LO_BIT 0x00000004
#define HSA_DBG_TRAP_DEBUG_WATCH_MASK_HI_BIT (29 << 4)

#define HSA_CAP_SRAM_EDCSUPPORTED 0x00080000
#define HSA_CAP_RESERVED_WAS_SRAM_EDCSUPPORTED 0x00080000 /* Old buggy user mode depends on this being 0 */
#define HSA_CAP_MEM_EDCSUPPORTED 0x00100000
#define HSA_CAP_RASEVENTNOTIFY 0x00200000
#define HSA_CAP_ASIC_REVISION_MASK 0x03c00000
#define HSA_CAP_ASIC_REVISION_SHIFT 22
#define HSA_CAP_SRAM_EDCSUPPORTED 0x04000000

#define HSA_CAP_RESERVED 0xfc078000
#define HSA_CAP_RESERVED 0xf80f8000

struct kfd_node_properties {
uint64_t hive_id;
Expand Down

0 comments on commit 6a986c0

Please sign in to comment.