Skip to content

Commit

Permalink
dma-buf: move dma-buf symbols into the DMA_BUF module namespace
Browse files Browse the repository at this point in the history
In order to better track where in the kernel the dma-buf code is used,
put the symbols in the namespace DMA_BUF and modify all users of the
symbols to properly import the namespace to not break the build at the
same time.

Now the output of modinfo shows the use of these symbols, making it
easier to watch for users over time:

$ modinfo drivers/misc/fastrpc.ko | grep import
import_ns:      DMA_BUF

Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: dri-devel@lists.freedesktop.org
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Acked-by: Christian König <christian.koenig@amd.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Sumit Semwal <sumit.semwal@linaro.org>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Link: https://lore.kernel.org/r/20211010124628.17691-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
gregkh authored and Flora Cui committed May 17, 2022
1 parent 5911b12 commit db1a7ee
Show file tree
Hide file tree
Showing 23 changed files with 66 additions and 17 deletions.
34 changes: 17 additions & 17 deletions drivers/dma-buf/dma-buf.c
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,7 @@ struct dma_buf *dma_buf_export(const struct dma_buf_export_info *exp_info)
module_put(exp_info->owner);
return ERR_PTR(ret);
}
EXPORT_SYMBOL_GPL(dma_buf_export);
EXPORT_SYMBOL_NS_GPL(dma_buf_export, DMA_BUF);

/**
* dma_buf_fd - returns a file descriptor for the given struct dma_buf
Expand All @@ -619,7 +619,7 @@ int dma_buf_fd(struct dma_buf *dmabuf, int flags)

return fd;
}
EXPORT_SYMBOL_GPL(dma_buf_fd);
EXPORT_SYMBOL_NS_GPL(dma_buf_fd, DMA_BUF);

/**
* dma_buf_get - returns the struct dma_buf related to an fd
Expand All @@ -645,7 +645,7 @@ struct dma_buf *dma_buf_get(int fd)

return file->private_data;
}
EXPORT_SYMBOL_GPL(dma_buf_get);
EXPORT_SYMBOL_NS_GPL(dma_buf_get, DMA_BUF);

/**
* dma_buf_put - decreases refcount of the buffer
Expand All @@ -664,7 +664,7 @@ void dma_buf_put(struct dma_buf *dmabuf)

fput(dmabuf->file);
}
EXPORT_SYMBOL_GPL(dma_buf_put);
EXPORT_SYMBOL_NS_GPL(dma_buf_put, DMA_BUF);

static void mangle_sg_table(struct sg_table *sg_table)
{
Expand Down Expand Up @@ -795,7 +795,7 @@ dma_buf_dynamic_attach(struct dma_buf *dmabuf, struct device *dev,
dma_buf_detach(dmabuf, attach);
return ERR_PTR(ret);
}
EXPORT_SYMBOL_GPL(dma_buf_dynamic_attach);
EXPORT_SYMBOL_NS_GPL(dma_buf_dynamic_attach, DMA_BUF);

/**
* dma_buf_attach - Wrapper for dma_buf_dynamic_attach
Expand All @@ -810,7 +810,7 @@ struct dma_buf_attachment *dma_buf_attach(struct dma_buf *dmabuf,
{
return dma_buf_dynamic_attach(dmabuf, dev, NULL, NULL);
}
EXPORT_SYMBOL_GPL(dma_buf_attach);
EXPORT_SYMBOL_NS_GPL(dma_buf_attach, DMA_BUF);

static void __unmap_dma_buf(struct dma_buf_attachment *attach,
struct sg_table *sg_table,
Expand Down Expand Up @@ -856,7 +856,7 @@ void dma_buf_detach(struct dma_buf *dmabuf, struct dma_buf_attachment *attach)

kfree(attach);
}
EXPORT_SYMBOL_GPL(dma_buf_detach);
EXPORT_SYMBOL_NS_GPL(dma_buf_detach, DMA_BUF);

/**
* dma_buf_pin - Lock down the DMA-buf
Expand Down Expand Up @@ -886,7 +886,7 @@ int dma_buf_pin(struct dma_buf_attachment *attach)

return ret;
}
EXPORT_SYMBOL_GPL(dma_buf_pin);
EXPORT_SYMBOL_NS_GPL(dma_buf_pin, DMA_BUF);

/**
* dma_buf_unpin - Unpin a DMA-buf
Expand All @@ -907,7 +907,7 @@ void dma_buf_unpin(struct dma_buf_attachment *attach)
if (dmabuf->ops->unpin)
dmabuf->ops->unpin(attach);
}
EXPORT_SYMBOL_GPL(dma_buf_unpin);
EXPORT_SYMBOL_NS_GPL(dma_buf_unpin, DMA_BUF);

/**
* dma_buf_map_attachment - Returns the scatterlist table of the attachment;
Expand Down Expand Up @@ -995,7 +995,7 @@ struct sg_table *dma_buf_map_attachment(struct dma_buf_attachment *attach,

return sg_table;
}
EXPORT_SYMBOL_GPL(dma_buf_map_attachment);
EXPORT_SYMBOL_NS_GPL(dma_buf_map_attachment, DMA_BUF);

/**
* dma_buf_unmap_attachment - unmaps and decreases usecount of the buffer;might
Expand Down Expand Up @@ -1031,7 +1031,7 @@ void dma_buf_unmap_attachment(struct dma_buf_attachment *attach,
!IS_ENABLED(CONFIG_DMABUF_MOVE_NOTIFY))
dma_buf_unpin(attach);
}
EXPORT_SYMBOL_GPL(dma_buf_unmap_attachment);
EXPORT_SYMBOL_NS_GPL(dma_buf_unmap_attachment, DMA_BUF);

/**
* dma_buf_move_notify - notify attachments that DMA-buf is moving
Expand All @@ -1051,7 +1051,7 @@ void dma_buf_move_notify(struct dma_buf *dmabuf)
if (attach->importer_ops)
attach->importer_ops->move_notify(attach);
}
EXPORT_SYMBOL_GPL(dma_buf_move_notify);
EXPORT_SYMBOL_NS_GPL(dma_buf_move_notify, DMA_BUF);

/**
* DOC: cpu access
Expand Down Expand Up @@ -1195,7 +1195,7 @@ int dma_buf_begin_cpu_access(struct dma_buf *dmabuf,

return ret;
}
EXPORT_SYMBOL_GPL(dma_buf_begin_cpu_access);
EXPORT_SYMBOL_NS_GPL(dma_buf_begin_cpu_access, DMA_BUF);

/**
* dma_buf_end_cpu_access - Must be called after accessing a dma_buf from the
Expand Down Expand Up @@ -1223,7 +1223,7 @@ int dma_buf_end_cpu_access(struct dma_buf *dmabuf,

return ret;
}
EXPORT_SYMBOL_GPL(dma_buf_end_cpu_access);
EXPORT_SYMBOL_NS_GPL(dma_buf_end_cpu_access, DMA_BUF);


/**
Expand Down Expand Up @@ -1265,7 +1265,7 @@ int dma_buf_mmap(struct dma_buf *dmabuf, struct vm_area_struct *vma,

return dmabuf->ops->mmap(dmabuf, vma);
}
EXPORT_SYMBOL_GPL(dma_buf_mmap);
EXPORT_SYMBOL_NS_GPL(dma_buf_mmap, DMA_BUF);

/**
* dma_buf_vmap - Create virtual mapping for the buffer object into kernel
Expand Down Expand Up @@ -1319,7 +1319,7 @@ int dma_buf_vmap(struct dma_buf *dmabuf, struct dma_buf_map *map)
mutex_unlock(&dmabuf->lock);
return ret;
}
EXPORT_SYMBOL_GPL(dma_buf_vmap);
EXPORT_SYMBOL_NS_GPL(dma_buf_vmap, DMA_BUF);

/**
* dma_buf_vunmap - Unmap a vmap obtained by dma_buf_vmap.
Expand All @@ -1343,7 +1343,7 @@ void dma_buf_vunmap(struct dma_buf *dmabuf, struct dma_buf_map *map)
}
mutex_unlock(&dmabuf->lock);
}
EXPORT_SYMBOL_GPL(dma_buf_vunmap);
EXPORT_SYMBOL_NS_GPL(dma_buf_vunmap, DMA_BUF);

#ifdef CONFIG_DEBUG_FS
static int dma_buf_debug_show(struct seq_file *s, void *unused)
Expand Down
3 changes: 3 additions & 0 deletions drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
#include <linux/swiotlb.h>
#include <linux/dma-buf.h>
#include <linux/sizes.h>
#include <linux/module.h>

#include <drm/drm_drv.h>
#include <drm/ttm/ttm_bo_api.h>
Expand All @@ -64,6 +65,8 @@
#include "amdgpu_res_cursor.h"
#include "bif/bif_4_1_d.h"

MODULE_IMPORT_NS(DMA_BUF);

#define AMDGPU_TTM_VRAM_MAX_DW_READ (size_t)128

struct amdgpu_dgma_node {
Expand Down
2 changes: 2 additions & 0 deletions drivers/gpu/drm/armada/armada_gem.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
#include "armada_gem.h"
#include "armada_ioctlP.h"

MODULE_IMPORT_NS(DMA_BUF);

static vm_fault_t armada_gem_vm_fault(struct vm_fault *vmf)
{
struct drm_gem_object *gobj = vmf->vma->vm_private_data;
Expand Down
3 changes: 3 additions & 0 deletions drivers/gpu/drm/drm_gem_framebuffer_helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
*/

#include <linux/slab.h>
#include <linux/module.h>

#include <drm/drm_damage_helper.h>
#include <drm/drm_fb_helper.h>
Expand All @@ -15,6 +16,8 @@
#include <drm/drm_gem_framebuffer_helper.h>
#include <drm/drm_modeset_helper.h>

MODULE_IMPORT_NS(DMA_BUF);

#define AFBC_HEADER_SIZE 16
#define AFBC_TH_LAYOUT_ALIGNMENT 8
#define AFBC_HDR_ALIGN 64
Expand Down
3 changes: 3 additions & 0 deletions drivers/gpu/drm/drm_prime.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
#include <linux/export.h>
#include <linux/dma-buf.h>
#include <linux/rbtree.h>
#include <linux/module.h>

#include <drm/drm.h>
#include <drm/drm_drv.h>
Expand All @@ -39,6 +40,8 @@

#include "drm_internal.h"

MODULE_IMPORT_NS(DMA_BUF);

/**
* DOC: overview and lifetime rules
*
Expand Down
3 changes: 3 additions & 0 deletions drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,13 @@

#include <drm/drm_prime.h>
#include <linux/dma-buf.h>
#include <linux/module.h>

#include "etnaviv_drv.h"
#include "etnaviv_gem.h"

MODULE_IMPORT_NS(DMA_BUF);

static struct lock_class_key etnaviv_prime_lock_class;

struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj)
Expand Down
3 changes: 3 additions & 0 deletions drivers/gpu/drm/exynos/exynos_drm_gem.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#include <linux/dma-buf.h>
#include <linux/pfn_t.h>
#include <linux/shmem_fs.h>
#include <linux/module.h>

#include <drm/drm_prime.h>
#include <drm/drm_vma_manager.h>
Expand All @@ -17,6 +18,8 @@
#include "exynos_drm_drv.h"
#include "exynos_drm_gem.h"

MODULE_IMPORT_NS(DMA_BUF);

static int exynos_drm_alloc_buf(struct exynos_drm_gem *exynos_gem, bool kvmap)
{
struct drm_device *dev = exynos_gem->base.dev;
Expand Down
3 changes: 3 additions & 0 deletions drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,14 @@
#include <linux/dma-buf.h>
#include <linux/highmem.h>
#include <linux/dma-resv.h>
#include <linux/module.h>

#include "i915_drv.h"
#include "i915_gem_object.h"
#include "i915_scatterlist.h"

MODULE_IMPORT_NS(DMA_BUF);

static struct drm_i915_gem_object *dma_buf_to_obj(struct dma_buf *buf)
{
return to_intel_bo(buf->priv);
Expand Down
2 changes: 2 additions & 0 deletions drivers/gpu/drm/omapdrm/omap_gem_dmabuf.c
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@

#include "omap_drv.h"

MODULE_IMPORT_NS(DMA_BUF);

/* -----------------------------------------------------------------------------
* DMABUF Export
*/
Expand Down
3 changes: 3 additions & 0 deletions drivers/gpu/drm/tegra/gem.c
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

#include <linux/dma-buf.h>
#include <linux/iommu.h>
#include <linux/module.h>

#include <drm/drm_drv.h>
#include <drm/drm_prime.h>
Expand All @@ -20,6 +21,8 @@
#include "drm.h"
#include "gem.h"

MODULE_IMPORT_NS(DMA_BUF);

static void tegra_bo_put(struct host1x_bo *bo)
{
struct tegra_bo *obj = host1x_to_tegra_bo(bo);
Expand Down
3 changes: 3 additions & 0 deletions drivers/gpu/drm/vmwgfx/ttm_object.c
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,11 @@
#include <linux/spinlock.h>
#include <linux/slab.h>
#include <linux/atomic.h>
#include <linux/module.h>
#include "ttm_object.h"

MODULE_IMPORT_NS(DMA_BUF);

/**
* struct ttm_object_file
*
Expand Down
3 changes: 3 additions & 0 deletions drivers/infiniband/core/umem_dmabuf.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,12 @@
#include <linux/dma-buf.h>
#include <linux/dma-resv.h>
#include <linux/dma-mapping.h>
#include <linux/module.h>

#include "uverbs.h"

MODULE_IMPORT_NS(DMA_BUF);

int ib_umem_dmabuf_map_pages(struct ib_umem_dmabuf *umem_dmabuf)
{
struct sg_table *sgt;
Expand Down
1 change: 1 addition & 0 deletions drivers/media/common/videobuf2/videobuf2-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -2967,3 +2967,4 @@ EXPORT_SYMBOL_GPL(vb2_thread_stop);
MODULE_DESCRIPTION("Media buffer core framework");
MODULE_AUTHOR("Pawel Osciak <pawel@osciak.com>, Marek Szyprowski");
MODULE_LICENSE("GPL");
MODULE_IMPORT_NS(DMA_BUF);
1 change: 1 addition & 0 deletions drivers/media/common/videobuf2/videobuf2-dma-contig.c
Original file line number Diff line number Diff line change
Expand Up @@ -755,3 +755,4 @@ EXPORT_SYMBOL_GPL(vb2_dma_contig_set_max_seg_size);
MODULE_DESCRIPTION("DMA-contig memory handling routines for videobuf2");
MODULE_AUTHOR("Pawel Osciak <pawel@osciak.com>");
MODULE_LICENSE("GPL");
MODULE_IMPORT_NS(DMA_BUF);
1 change: 1 addition & 0 deletions drivers/media/common/videobuf2/videobuf2-dma-sg.c
Original file line number Diff line number Diff line change
Expand Up @@ -666,3 +666,4 @@ EXPORT_SYMBOL_GPL(vb2_dma_sg_memops);
MODULE_DESCRIPTION("dma scatter/gather memory handling routines for videobuf2");
MODULE_AUTHOR("Andrzej Pietrasiewicz");
MODULE_LICENSE("GPL");
MODULE_IMPORT_NS(DMA_BUF);
1 change: 1 addition & 0 deletions drivers/media/common/videobuf2/videobuf2-vmalloc.c
Original file line number Diff line number Diff line change
Expand Up @@ -444,3 +444,4 @@ EXPORT_SYMBOL_GPL(vb2_vmalloc_memops);
MODULE_DESCRIPTION("vmalloc memory handling routines for videobuf2");
MODULE_AUTHOR("Pawel Osciak <pawel@osciak.com>");
MODULE_LICENSE("GPL");
MODULE_IMPORT_NS(DMA_BUF);
1 change: 1 addition & 0 deletions drivers/misc/fastrpc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1763,3 +1763,4 @@ static void fastrpc_exit(void)
module_exit(fastrpc_exit);

MODULE_LICENSE("GPL v2");
MODULE_IMPORT_NS(DMA_BUF);
2 changes: 2 additions & 0 deletions drivers/misc/habanalabs/common/memory.c
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
#include <linux/uaccess.h>
#include <linux/slab.h>

MODULE_IMPORT_NS(DMA_BUF);

#define HL_MMU_DEBUG 0

/* use small pages for supporting non-pow2 (32M/40M/48M) DRAM phys page sizes */
Expand Down
3 changes: 3 additions & 0 deletions drivers/staging/media/tegra-vde/dmabuf-cache.c
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,12 @@
#include <linux/sched.h>
#include <linux/slab.h>
#include <linux/workqueue.h>
#include <linux/module.h>

#include "vde.h"

MODULE_IMPORT_NS(DMA_BUF);

struct tegra_vde_cache_entry {
enum dma_data_direction dma_dir;
struct dma_buf_attachment *a;
Expand Down
3 changes: 3 additions & 0 deletions drivers/tee/tee_shm.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,11 @@
#include <linux/slab.h>
#include <linux/tee_drv.h>
#include <linux/uio.h>
#include <linux/module.h>
#include "tee_private.h"

MODULE_IMPORT_NS(DMA_BUF);

static void release_registered_pages(struct tee_shm *shm)
{
if (shm->pages) {
Expand Down
1 change: 1 addition & 0 deletions drivers/virtio/virtio_dma_buf.c
Original file line number Diff line number Diff line change
Expand Up @@ -86,3 +86,4 @@ int virtio_dma_buf_get_uuid(struct dma_buf *dma_buf,
EXPORT_SYMBOL(virtio_dma_buf_get_uuid);

MODULE_LICENSE("GPL");
MODULE_IMPORT_NS(DMA_BUF);
3 changes: 3 additions & 0 deletions drivers/xen/gntdev-dmabuf.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,16 @@
#include <linux/slab.h>
#include <linux/types.h>
#include <linux/uaccess.h>
#include <linux/module.h>

#include <xen/xen.h>
#include <xen/grant_table.h>

#include "gntdev-common.h"
#include "gntdev-dmabuf.h"

MODULE_IMPORT_NS(DMA_BUF);

#ifndef GRANT_INVALID_REF
/*
* Note on usage of grant reference 0 as invalid grant reference:
Expand Down
1 change: 1 addition & 0 deletions samples/vfio-mdev/mbochs.c
Original file line number Diff line number Diff line change
Expand Up @@ -1476,5 +1476,6 @@ static void __exit mbochs_dev_exit(void)
mbochs_class = NULL;
}

MODULE_IMPORT_NS(DMA_BUF);
module_init(mbochs_dev_init)
module_exit(mbochs_dev_exit)

0 comments on commit db1a7ee

Please sign in to comment.