This repository has been archived by the owner on Jan 26, 2024. It is now read-only.
[NFC} Update description of OMPGridValues enums #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<Only for pre-phab review, not to be committed here> Updated comments describing how OMPGridValues enums will be used in clang, deviceRTLs, and hsa and cuda plugins.
ronlieb
reviewed
Aug 11, 2020
gregrodgers
approved these changes
Aug 18, 2020
|
I don't understand your first comment about not to be merged. I like the comment update and would like this merged into AOMP. |
No, I haven't committed it anywhere else. |
My plan was to put it as an upstream patch first and then let it come to this branch. But, you can merge it, I will post it upstream as well. |
|
[AMD Public Use]
How about just putting it upstream first.
From: Saiyedul Islam <notifications@github.com>
Sent: Wednesday, August 19, 2020 9:55 AM
To: ROCm-Developer-Tools/amd-llvm-project <amd-llvm-project@noreply.github.com>
Cc: Lieberman, Ron <Ron.Lieberman@amd.com>; Review requested <review_requested@noreply.github.com>
Subject: Re: [ROCm-Developer-Tools/amd-llvm-project] [NFC} Update description of OMPGridValues enums (#118)
[CAUTION: External Email]
I don't understand your first comment about not to be merged. I like the comment update and would like this merged into AOMP.
My plan was to put it as an upstream patch first and then let it come to this branch. But, you can commit it, I will post it upstream as well.
-
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FROCm-Developer-Tools%2Famd-llvm-project%2Fpull%2F118%23issuecomment-676476833&data=02%7C01%7Cron.lieberman%40amd.com%7C4c0f64fad8474ec9aa7608d8444fe19c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637334457759105315&sdata=Q0uQzREgCATpqOZ9%2BKS8Rw6RHDYohW%2BBOSn6CG5cnqg%3D&reserved=0>, or unsubscribe<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD3EYZYIQ5VER7QWRIQZIV3SBPRVFANCNFSM4POP7J3Q&data=02%7C01%7Cron.lieberman%40amd.com%7C4c0f64fad8474ec9aa7608d8444fe19c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637334457759105315&sdata=CIknj2RkVv1S4MGikP%2Bipe7d3fgRcyg7iyJt9ZdjPSA%3D&reserved=0>.
|
|
Here is the corresponding phab review: https://reviews.llvm.org/D86232 |
|
The phab review is closed. amd-stg-open has presumably caught the update by now. Do we need to change aomp to match? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Only for pre-phab review, not to be committed/merged in this repo>
Updated comments describing how OMPGridValues enums will be used in clang, deviceRTLs, and hsa and cuda plugins.
Please suggest if any other future use of these enums is not mentioned here.