This repository has been archived by the owner on Jan 26, 2024. It is now read-only.
Build hostrpc with fewer includes, nogpulib #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now built on various systems. The file this affects is hostrpc-amdgcn.bc, which doesn't (and need not) use anything from rocm. |
DeepCode failed to analyze this pull requestSomething went wrong despite trying multiple times, sorry about that. |
|
JC, merge this if you are ready. |
estewart08
suggested changes
Oct 28, 2020
| @@ -101,13 +101,10 @@ macro(add_openmp_library libname archname dir) | |||
| -fopenmp-targets=${triple} | |||
| -Xopenmp-target=${triple} | |||
| -march=${GPU} | |||
| -nogpulib | |||
There was a problem hiding this comment.
I believe we can add -nogpuinc here as well to avoid looking for hip runtime.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't believe the includes are required, and passing -nogpulib works around failures to find an appropriate rocm install.