This repository has been archived by the owner on Jan 26, 2024. It is now read-only.
Accept pointer or array for deviceState #222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonChesterfield
requested review from
gregrodgers,
ronlieb,
estewart08,
saiislam and
pdhaliwal-amd
|
Gerrit 451651 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nvptx and trunk amdgcn use a global array for deviceState. aomp and rocm use a void *, allocated and initialized by the runtime.
This change restructures the setup of that deviceState by assuming that a symbol greater in size than a void * is already an appropriate global array.
Checked against a deviceRTL that uses the global array - still works, still slower than the alloc+zero strategy.