Fix compilation errors with musl libc #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngryLoki
added a commit
to AngryLoki/gentoo
that referenced
this pull request
May 22, 2024
Upstream pull-requests: * ROCm/clr#83 * ROCm/hip-tests#463 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
littlewu2508
pushed a commit
to littlewu2508/gentoo
that referenced
this pull request
May 23, 2024
Upstream pull-requests: * ROCm/clr#83 * ROCm/hip-tests#463 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
AngryLoki
added a commit
to AngryLoki/gentoo
that referenced
this pull request
Jun 11, 2024
Upstream pull-requests: * ROCm/clr#83 * ROCm/hip-tests#463 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
negril
pushed a commit
to negril/gentoo
that referenced
this pull request
Jun 25, 2024
Upstream pull-requests: * ROCm/clr#83 * ROCm/hip-tests#463 Signed-off-by: Sv. Lockal <lockalsash@gmail.com> Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
negril
pushed a commit
to negril/gentoo
that referenced
this pull request
Jun 25, 2024
Upstream pull-requests: * ROCm/clr#83 * ROCm/hip-tests#463 Signed-off-by: Sv. Lockal <lockalsash@gmail.com> Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
negril
pushed a commit
to negril/gentoo
that referenced
this pull request
Jun 25, 2024
Upstream pull-requests: * ROCm/clr#83 * ROCm/hip-tests#463 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jun 26, 2024
Upstream pull-requests: * ROCm/clr#83 * ROCm/hip-tests#463 Signed-off-by: Sv. Lockal <lockalsash@gmail.com> Signed-off-by: Sam James <sam@gentoo.org>
1. According to POSIX specification, basename(3) belongs to libgen.h 2. __cpu_mask is an internal type of glibc's cpu_set implementation, not part of the POSIX definition, so musl does not support it too. Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
|
@gargrahul , could you check this, please? |
|
Hi @AngryLoki, Thank you for submitting this PR. This would address the issue, but I wouldn't want to reference this typename in the code at all. Instead, in the few places it is referenced within This would also address the musl compilation issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libgen.h[1]__cpu_maskis an internal type of glibc's cpu_set implementation, not part of the POSIX specification, so musl does not support it too.[1] https://man7.org/linux/man-pages/man3/basename.3.html