[CK_TILE] Add EnvLogging and missing gemm args checks #1896
+266
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aledudek
requested review from
illsilin,
carlushuang,
qianfengz,
aosewski,
poyenc,
geyyer,
bartekxk,
andriy-ca and
afagaj
as code owners
aosewski
reviewed
Feb 21, 2025
mozga-amd
reviewed
Feb 21, 2025
| }; | ||
| } // end namespace internal | ||
|
|
||
| // static inside function hides the variable and provides |
There was a problem hiding this comment.
static -> Static... here, other. UpperCase at the beginning
| } | ||
| } | ||
|
|
||
| if(value_env_str == "disable" || value_env_str == "disabled" || value_env_str == "0" || |
There was a problem hiding this comment.
Either:
What do you think about turning these strings into a map, an enum, or another structure… to avoid explicitly listing the arguments here?
Or:
To avoid explicitly listing arguments separated by ||, you can use ck_tile::is_any_of.
Or:
std::any_of and static constexpr const char* array[]
Here and below
| throw std::runtime_error("Invalid value for env variable"); | ||
| } | ||
|
|
||
| return false; // shouldn't reach here |
There was a problem hiding this comment.
The comment seems to be unnecessary?
| std::cerr << "N is not a multiple of vector load size for C tensor!" << std::endl; | ||
| if(ck_tile::EnvIsEnabled(CK_TILE_ENV(CK_TILE_LOGGING))) | ||
| { | ||
| std::cerr << "N is not a multiple of vector load size for C tensor!" |
There was a problem hiding this comment.
Maybe it could be fine to add FAILED, WARNING? at the beginning?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Please describe the motivation behind the pull request, whether it enables a new feature or fixes a bug. If there are associated pull requests or issues, please link them to the pull request.
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered