Skip to content

Conversation

johannes-graner
Copy link
Contributor

Proposed changes

Fixes a race condition in the remod script run by pre-commit that occasionally leads to truncated files.
See failed and successful runs for the same commit as an example.

The fix consists of two parts:

  1. Making sure that dos2unix is run before clang-format for a given file.
  2. Waiting for all subprocesses to finish before generating headers (include) or exiting (examples).

Thanks @DDEle for bringing this to my attention!

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

@johannes-graner johannes-graner merged commit 4043401 into develop Oct 21, 2025
48 checks passed
@johannes-graner johannes-graner deleted the jograner/fix-remod-race-condition branch October 21, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants