(WIP) Update device workspace usage #921
Draft
+1,375
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmachado-amd
added
noOptimizations
jmachado-amd
requested review from
jzuniga-amd,
tfalders,
cgmb,
qjojo,
EdDAzevedo and
AGonzales-amd
as code owners
EdDAzevedo
reviewed
Mar 28, 2025
| throw(std::domain_error("Error at merge::merge_item(): id >= N")); | ||
| } | ||
|
|
||
| std::size_t size = std::max(size_, w_out.size(id)); |
There was a problem hiding this comment.
Is merge() mean always taking the max, and join() mean taking the sum? Maybe some comments can be helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR includes initial code to make device workspace memory management internal to individual
roclapack_*androcauxiliary_*methods. This is a work in progress, meant to illustrate where we might go if decide to keep rocSOLVER's original approach to manage device memory.