Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the heuristic logic for fp8 weight padding #279

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

charlifu
Copy link

@charlifu charlifu commented Nov 14, 2024

This PR improves the condition of padding weight to only when the size of last dimension % 512 = 0.

@charlifu charlifu requested review from gshtras and shajrawi November 14, 2024 16:19
@shajrawi shajrawi merged commit 5362727 into develop Nov 14, 2024
9 of 10 checks passed
@shajrawi shajrawi deleted the charlifu/padding_improve branch November 14, 2024 16:34
@shajrawi
Copy link
Collaborator

Merging ASAP as we are starting a nightly docker build early in the day

@divakar-amd
Copy link

divakar-amd commented Nov 19, 2024

@charlifu I believe we would also want to pad here (for tuning):

w1 = torch.randn(num_experts,
shard_intermediate_size,
hidden_size,
dtype=init_dtype)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants