Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradlib torch extension cmake #282

Merged
merged 7 commits into from
Nov 15, 2024
Merged

Conversation

gshtras
Copy link
Collaborator

@gshtras gshtras commented Nov 15, 2024

Building gradlib as an extension module for vllm rather than a separate library.
Replaced pybind11 with torch_library for python binding

@gshtras gshtras force-pushed the gradlib_torch_extension_cmake branch from 5a93fbc to 1c8fea8 Compare November 15, 2024 19:47
Copy link

@maleksan85 maleksan85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gshtras gshtras merged commit 48726bf into develop Nov 15, 2024
8 of 9 checks passed
@gshtras gshtras deleted the gradlib_torch_extension_cmake branch November 15, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants