Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use unified fp8 notation in FA #483

Merged
merged 1 commit into from
Mar 14, 2025
Merged

use unified fp8 notation in FA #483

merged 1 commit into from
Mar 14, 2025

Conversation

divakar-amd
Copy link

@divakar-amd
use current_platform.fp8_dtype() for FA
8865375 
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
gshtras
gshtras approved these changes Mar 14, 2025
View reviewed changes
Copy link
Collaborator

@gshtras gshtras left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @rasmith for upstreaming FP8 FA

@divakar-amd divakar-amd merged commit 9d4368d into main Mar 14, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshtras gshtras gshtras approved these changes

@charlifu charlifu Awaiting requested review from charlifu charlifu is a code owner

@mawong-amd mawong-amd Awaiting requested review from mawong-amd mawong-amd is a code owner

@shajrawi shajrawi Awaiting requested review from shajrawi shajrawi is a code owner

@maleksan85 maleksan85 Awaiting requested review from maleksan85 maleksan85 is a code owner

@sunway513 sunway513 Awaiting requested review from sunway513 sunway513 is a code owner

@hongxiayang hongxiayang Awaiting requested review from hongxiayang hongxiayang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@divakar-amd @gshtras