Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #17432: [ROCm] Skip Parametric/TestF16/MajorToMinor tests as it re… #88

Open
wants to merge 1 commit into
base: rocm-jaxlib-v0.4.35-qa
Choose a base branch
from

Conversation

hsharsha
Copy link

@hsharsha hsharsha commented Jan 7, 2025

…quires trit…

Imported from GitHub PR openxla#17432

…on gemm

This fails due to cce3b37 which disables triton gemm on ROCm. Copybara import of the project:

--
9a47e05 by Harsha HS Harsha.HavanurShamsundara@amd.com:

[ROCm] Skip Parametric/TestF16/MajorToMinor tests as it requires triton gemm

Merging this change closes openxla#17432

COPYBARA_INTEGRATE_REVIEW=openxla#17432 from ROCm:ci_skip_dot_tests_on_ROCm_20240924 9a47e05 PiperOrigin-RevId: 688477932

…s it requires trit…

Imported from GitHub PR openxla#17432

…on gemm

This fails due to cce3b37 which disables triton gemm on ROCm.
Copybara import of the project:

--
9a47e05 by Harsha HS <Harsha.HavanurShamsundara@amd.com>:

[ROCm] Skip Parametric/TestF16/MajorToMinor tests as it requires triton gemm

Merging this change closes openxla#17432

COPYBARA_INTEGRATE_REVIEW=openxla#17432 from ROCm:ci_skip_dot_tests_on_ROCm_20240924 9a47e05
PiperOrigin-RevId: 688477932
@hsharsha hsharsha requested a review from i-chaochen February 7, 2025 12:51
Copy link

@i-chaochen i-chaochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, this test is skipped due to cce3b37 has disabled triton auotune, but since #81 is merged, I assume it should be ok now?

cc @zoranjovanovic-ns

@zoranjovanovic-ns
Copy link

IIUC, this test is skipped due to cce3b37 has disabled triton auotune, but since #81 is merged, I assume it should be ok now?

The test disables autotuner by setting xla_gpu_autotune_level to 0, but requires Triton, which is enabled now.
If test still fails it should be investigated why (missing autotuner functionality cannot be the reason anymore).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants