-
Notifications
You must be signed in to change notification settings - Fork 5
fix(build): improve Rust toolchain detection on Windows #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
fix(build): improve Rust toolchain detection on Windows, add relevant rustfmt.exe path |
|
Could you update the CI workflow to include Windows in the matrix? Specifically, please modify the |
|
|
Sorry, I didn't notice this. Let me take a look at it tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances Windows compatibility for the RPL toolchain by improving Rust toolchain detection on Windows systems. The changes ensure the build process correctly locates rustfmt.exe on Windows platforms and adds CI testing for Windows.
Key changes:
- Fixed rustfmt executable detection to use
.exeextension on Windows - Added Windows to the CI matrix for continuous testing
- Documented Windows-specific setup requirements
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/rpl_parser/build.rs | Platform-specific rustfmt executable detection for Windows compatibility |
| README.md | Added Windows-specific installation instructions for RUSTUP_HOME setup |
| .github/workflows/main.yml | Extended CI to test on Windows and added cargo caching |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| ## Quick Start | ||
|
|
||
| 1. Clone the repository and enter the directory: `git clone https://github.com/RPL-Toolchain/RPL.git && cd RPL` | ||
| 1. Clone the repository and enter the directory: `git clone https://github.com/RPL-Toolchain/RPL.git && cd RPL` (When Used on Windows, you should first set your RUSTUP_HOME environment variable, normally `%USERPROFILE%\.rustup`) |
Copilot
AI
Oct 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected capitalization of 'Used' to 'used'.
| 1. Clone the repository and enter the directory: `git clone https://github.com/RPL-Toolchain/RPL.git && cd RPL` (When Used on Windows, you should first set your RUSTUP_HOME environment variable, normally `%USERPROFILE%\.rustup`) | |
| 1. Clone the repository and enter the directory: `git clone https://github.com/RPL-Toolchain/RPL.git && cd RPL` (When used on Windows, you should first set your RUSTUP_HOME environment variable, normally `%USERPROFILE%\.rustup`) |
| ~/.cargo/registry | ||
| ~/.cargo/git |
Copilot
AI
Oct 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cache paths use Unix-style home directory paths (~/.cargo/) which won't work correctly on Windows. Consider using ${{ runner.tool_cache }} or platform-specific paths, or use a conditional cache configuration per OS.
| ~/.cargo/registry | |
| ~/.cargo/git | |
| ${{ runner.os == 'Windows' && env.USERPROFILE || '~' }}/.cargo/registry | |
| ${{ runner.os == 'Windows' && env.USERPROFILE || '~' }}/.cargo/git |
Set default shell to bash for job runs.
Removed environment variable CARGO_TERM_COLOR from workflow.
|
It's weird that ''s aren't normalized to '/' by ui-test, and maybe I can debug this on a PC tomorrow or this weekend. |
See config.rs in |
|
It seems that the bug has been fixed in |
No description provided.