Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #24 #25

Merged
merged 1 commit into from
Jul 13, 2023
Merged

fixes #24 #25

merged 1 commit into from
Jul 13, 2023

Conversation

JanLJL
Copy link
Contributor

@JanLJL JanLJL commented Jul 13, 2023

See #24

@JanLJL JanLJL requested a review from TomTheBear July 13, 2023 08:29
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -4.58 ⚠️

Comparison is base (d218701) 84.45% compared to head (a3ae29c) 79.87%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage   84.45%   79.87%   -4.58%     
==========================================
  Files          14       14              
  Lines        3995     3996       +1     
==========================================
- Hits         3374     3192     -182     
- Misses        621      804     +183     
Impacted Files Coverage Δ
machinestate.py 68.60% <0.00%> (-7.08%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@TomTheBear TomTheBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@TomTheBear TomTheBear merged commit 85cbd71 into master Jul 13, 2023
7 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants