refactor: revamp z-index usage #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lawvs is attempting to deploy a commit to the RSS3 Team on Vercel. A member of the Team first needs to authorize it. |
lawvs
force-pushed
the
refactor/z-index
branch
2 times, most recently
from
6c792c4
to
5428f8f
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lawvs
force-pushed
the
refactor/z-index
branch
from
52bd906
to
19d3317
Compare
Innei
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request revamps the z-index usage across the application, simplifying the modal structure and overlay handling.
Unnecessary z-index values have been removed from components, leading to a cleaner and more maintainable codebase.
But this pull request breaks some cases in the modal overlay and may not meet all business scenarios.
Related to #859
See also Stop (ab)using z-index