Skip to content

Conversation

@wdfk-prog
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

Copilot AI and others added 12 commits October 28, 2025 23:28
Co-authored-by: BernardXiong <1241087+BernardXiong@users.noreply.github.com>
Co-authored-by: BernardXiong <1241087+BernardXiong@users.noreply.github.com>
Co-authored-by: BernardXiong <1241087+BernardXiong@users.noreply.github.com>
Co-authored-by: BernardXiong <1241087+BernardXiong@users.noreply.github.com>
Co-authored-by: BernardXiong <1241087+BernardXiong@users.noreply.github.com>
Co-authored-by: BernardXiong <1241087+BernardXiong@users.noreply.github.com>
Co-authored-by: BernardXiong <1241087+BernardXiong@users.noreply.github.com>
Co-authored-by: BernardXiong <1241087+BernardXiong@users.noreply.github.com>
Co-authored-by: BernardXiong <1241087+BernardXiong@users.noreply.github.com>
Co-authored-by: BernardXiong <1241087+BernardXiong@users.noreply.github.com>
@supperthomas
Copy link
Member

image 分支改下

@supperthomas supperthomas changed the base branch from copilot/update-elm-fatfs-to-r016 to master November 5, 2025 08:44
@supperthomas
Copy link
Member

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ wdfk-prog
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

@Rbb666
Copy link
Member

Rbb666 commented Nov 7, 2025

@wdfk-prog

这个PR看起来是更新了fatfs的版本?

也麻烦在pr说明中说明下,以及附上此上游的链接

@github-actions
Copy link

github-actions bot commented Nov 9, 2025

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/dfs/dfs_v1/filesystems/elmfat/00history.txt
  • components/dfs/dfs_v1/filesystems/elmfat/00readme.txt
  • components/dfs/dfs_v1/filesystems/elmfat/dfs_elm.c
  • components/dfs/dfs_v1/filesystems/elmfat/diskio.h
  • components/dfs/dfs_v1/filesystems/elmfat/ff.c
  • components/dfs/dfs_v1/filesystems/elmfat/ff.h
  • components/dfs/dfs_v1/filesystems/elmfat/ffconf.h
  • components/dfs/dfs_v1/filesystems/elmfat/ffunicode.c
  • components/dfs/dfs_v2/filesystems/elmfat/00history.txt
  • components/dfs/dfs_v2/filesystems/elmfat/00readme.txt
  • components/dfs/dfs_v2/filesystems/elmfat/diskio.h
  • components/dfs/dfs_v2/filesystems/elmfat/ff.c
  • components/dfs/dfs_v2/filesystems/elmfat/ff.h
  • components/dfs/dfs_v2/filesystems/elmfat/ffconf.h

📊 Current Review Status (Last Updated: 2025-11-09 10:39 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants