Open
Conversation
Toouren
reviewed
Mar 18, 2021
| if(time.hours > this.hours) | ||
| return true; | ||
| else | ||
| { |
There was a problem hiding this comment.
С такой проверкой время 8:40 будет не раньше чем 10:50, а это логическая ошибка
Toouren
reviewed
Mar 18, 2021
| Time.prototype.isLater = function(time){ | ||
| if(time.hours < this.hours) | ||
| return true; | ||
| else |
There was a problem hiding this comment.
Тут кажется та же логическая ошибка, что и в isEarlier
Toouren
reviewed
Mar 18, 2021
src/task_2/index.js
Outdated
| }; | ||
|
|
||
| Meeting.prototype.isMeetingInTimeRange = function(start, end){ | ||
| if (this.startTime.hours == start.hours) |
Toouren
reviewed
Mar 18, 2021
src/task_2/index.js
Outdated
| Meeting.prototype.isMeetingInTimeRange = function(start, end){ | ||
| if (this.startTime.hours == start.hours) | ||
| { | ||
| if (this.endTime.hours < end.hours) return true; |
There was a problem hiding this comment.
Любые блоки даже те, которые состоят из 1 строки, лучше выделять фигурными скобками и писать с новой строки. Так легче читать чужой код
Toouren
reviewed
Mar 18, 2021
| this.meetings = meetings; | ||
| this.vacations = vacations; | ||
| }; | ||
|
|
Toouren
reviewed
Mar 18, 2021
src/task_3/index.js
Outdated
| function Vacation(vacationStartDate, vacationEndDate) { }; | ||
| function Vacation(vacationStartDate, vacationEndDate) { | ||
| if (vacationStartDate > vacationEndDate || | ||
| (vacationStartDate.getDate() == vacationEndDate.getDate())) throw new Error(); |
Toouren
reviewed
Mar 18, 2021
src/task_3/index.js
Outdated
|
|
||
| Vacation.prototype.isDateInVacation = function(date){ | ||
| if (this.vacationStartDate.getDate() <= date.getDate() && this.vacationEndDate.getDate() >= date.getDate() && | ||
| date.getFullYear() == this.vacationStartDate.getFullYear()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.