-
Notifications
You must be signed in to change notification settings - Fork 10
Комаров Ярослав #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
YaroslavKomarov
wants to merge
1
commit into
RTF-Angular-2021:master
Choose a base branch
from
YaroslavKomarov:Komarov-Yaroslav
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| let user: User = new User(19, 'Yaroslav'); | ||
| user.upAgeByYear(); | ||
|
|
||
| console.log(user.age); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| interface ICustom { | ||
| user: User; | ||
| } | ||
|
|
||
| declare var Custom: ICustom; | ||
|
|
||
| declare class User { | ||
| public age: number; | ||
| public name: string; | ||
| constructor(a: number, n: string); | ||
| public upAgeByYear(): void; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import {SettingValue, Setting} from './setting'; | ||
|
|
||
| class Example { | ||
| public title?: string; | ||
| public id?: number; | ||
| private _setting: Setting; | ||
|
|
||
| constructor(s: Setting) { | ||
| this._setting = s; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="ru"> | ||
|
|
||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>Заголовок</title> | ||
| </head> | ||
|
|
||
| <body> | ||
| <script data-main="./example.js" | ||
| src="https://requirejs.org/docs/release/2.3.6/minified/require.js"> | ||
| </script> | ||
| </body> | ||
| </html> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Всё правильно |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import {SettingValue} from './setting_val'; | ||
|
|
||
| class Setting { | ||
| public key: string; | ||
| public value: SettingValue; | ||
|
|
||
| constructor(k: string, ov: SettingValue) { | ||
| this.key = k; | ||
| this.value = ov; | ||
| } | ||
| } | ||
|
|
||
| export {SettingValue, Setting}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| export class SettingValue { | ||
| public property1: string; | ||
| public property2: string; | ||
|
|
||
| constructor(p1: string, p2: string) { | ||
| this.property1 = p1; | ||
| this.property2 = p2; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,33 +16,48 @@ class HttpError extends Error { | |
| } | ||
| } | ||
|
|
||
| function req(url: string): Promise<IUser> { | ||
| return fetch(url) | ||
| .then((response: Response) => { | ||
| if (response.status == 200) { | ||
| return response.json(); | ||
| } else { | ||
| throw new HttpError(response); | ||
| } | ||
| }) | ||
| async function req(url: string): Promise<IUser> { | ||
| const response = await fetch(url); | ||
| if(response.status === 200) { | ||
| return await response.json() | ||
| } | ||
| throw new HttpError(response); | ||
| // return fetch(url) | ||
| // .then((response: Response) => { | ||
| // if (response.status == 200) { | ||
| // return response.json(); | ||
| // } else { | ||
| // throw new HttpError(response); | ||
| // } | ||
| // }) | ||
| } | ||
|
|
||
| // Запрашивать логин, пока github не вернёт существующего пользователя. | ||
| function getGitHub() { | ||
| async function getGitHub() { | ||
| let name = prompt("Введите логин на GitHub?", ""); | ||
|
|
||
| return req(`https://api.github.com/users/${name}`) | ||
| .then(user => { | ||
| document.write(`Полное имя: ${user.name}, уникальный номер: ${user.id}.`); | ||
| return user; | ||
| }) | ||
| .catch(err => { | ||
| if (err instanceof HttpError && err.response.status == 404) { | ||
| document.write("Такого пользователя не существует."); | ||
| } else { | ||
| throw err; | ||
| } | ||
| }); | ||
| try { | ||
| const user = await req(`https://api.github.com/users/${name}`); | ||
| document.write(`Полное имя: ${user.name}, уникальный номер: ${user.id}.`); | ||
| } catch(err) { | ||
| if (err instanceof HttpError && err.response.status == 404) { | ||
| document.write("Такого пользователя не существует."); | ||
| } else { | ||
| throw err; | ||
| } | ||
| } | ||
| // return req(`https://api.github.com/users/${name}`) | ||
| // .then(user => { | ||
| // document.write(`Полное имя: ${user.name}, уникальный номер: ${user.id}.`); | ||
| // return user; | ||
| // }) | ||
| // .catch(err => { | ||
| // if (err instanceof HttpError && err.response.status == 404) { | ||
| // document.write("Такого пользователя не существует."); | ||
| // } else { | ||
| // throw err; | ||
| // } | ||
| // }); | ||
| } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 3 бала |
||
|
|
||
| getGitHub(); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
правильно
3 бала