Skip to content

Add python function cuda_image_from_image and test #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

axel-grc
Copy link

@axel-grc axel-grc commented Mar 13, 2025

Ready to merge

@SimonRit
Copy link
Collaborator

Is this ready to be merged?

@axel-grc
Copy link
Author

Is this ready to be merged?

Not yet, I moved cuda_image_from_image function to a separate file but it doesn't seems to work for now, I'm trying to fix it.

@axel-grc axel-grc changed the title ENH: Add python function cuda_image_from_image Add python function cuda_image_from_image and test Mar 19, 2025
Copy link
Collaborator

@SimonRit SimonRit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. However, CudaImage is always available in this module so shouldn't we simplify the code and remove all if hasattr(itk, 'CudaImage'): and the corresponding else:?

@SimonRit
Copy link
Collaborator

Sorry, I didn't intend to close it with my force-push... Can you reopen one based on this change please?

@SimonRit
Copy link
Collaborator

See #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants