Skip to content

Conversation

@SimonRit
Copy link
Collaborator

No description provided.

@SimonRit SimonRit force-pushed the CudaCommon_v2 branch 5 times, most recently from 244c9ee to 86ba52d Compare September 17, 2025 08:24
@SimonRit
Copy link
Collaborator Author

@LucasGandel We are in the process of testing RTKConsortium/ITKCudaCommon#43. I wanted to generate RTK packages compatible with this PR and it turns out that I need to modify ITKPythonPackages, see here. I think we should move cudaCommonConfiguration.h.in to the include directory but for CudaImage.i.in and CudaImage.i.init, I don't have a better solution than patching ITKPythonPackage. What do you think?

@SimonRit
Copy link
Collaborator Author

SimonRit commented Oct 3, 2025

This is ready to be merged but the Python tests will fail until a new version of CudaCommon is released. I suggest we wait for the release of Python packages before merging it.

@SimonRit
Copy link
Collaborator Author

SimonRit commented Oct 7, 2025

We have compilation problems on main without this PR. Merging it, Python tests will fail until CudaCommon's release.

@SimonRit SimonRit merged commit acdcea2 into RTKConsortium:main Oct 7, 2025
45 of 52 checks passed
@SimonRit SimonRit deleted the CudaCommon_v2 branch October 7, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant