Sprint end pull request #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Period (17.04-06.05)
Added title/description for workflow and for steps, made it possible to remove steps (added confirmatiion dialog for that, just to be sure), made first start to adding rules (including lines between steps, though I'm not yet finished with that). Lots of other tiny changes (mostly layout).
Needs some fixing..
When a chart type is changed for a certain result step, it is changed for every result step to be of same type.
-Rule removal when adding level between, rule removal when removing node. Rules not yet added to the database. -Start to getting result structure of API-call. Retrieve accessible fields from current location (useful for API-call mapping) -Fixed bug caused by removing steps
-Rule removal when adding level between, rule removal when removing node. Rules not yet added to the database. -Start to getting result structure of API-call (useful for result representation and rules) . Retrieve accessible fields from current location (useful for API-call mapping) -Fixed bug caused by removing steps
workflow page loads level 0 step and will run the Evidencio model associated with that Step. Created a search modal for designer-end
Haven't really tested it a lot, might be buggy. Was a pain to implement due to the A part of AJAX calls. Things to fix: - Update title/colour of rule targets each modal change
change graph from post to get
Update graph.blade.php
Update WorkflowStep.vue
Timetracking
Daanra
reviewed
Jun 24, 2018
| ]); | ||
|
|
||
| if(array_key_exists('file',$data)) |
| * | ||
| * @param Number $workflowId | ||
| * @return Array | ||
| * @param HTTP|Request $request Post request containing a Evidencio Model Search |
| * @param Number $workflowId | ||
| * @return Array | ||
| * @param HTTP|Request $request Post request containing a Evidencio Model Search | ||
| * @return JSON Evidencio models |
| * Should the workflowId be given, that workflow will be updated. | ||
| * | ||
| * @param HTTP|Request $request Post request withWorkflow data (title/description, steps, etc.) | ||
| * @param Number $workflowId |
There was a problem hiding this comment.
Sorry, confusion due to Javascript
| return view('myworkflows', compact('workflows')); | ||
| } | ||
|
|
||
| public function deleteWorkflow($id) |
There was a problem hiding this comment.
Something like:
/**
* Deletes a Workflow
* @param int $id The id of the Workflow
* @return void
*/
It is also missing type hints.
|
|
||
| if($(".add-document").is(":hidden") && appRegistration.fileList.length < appRegistration.maxFileNum) | ||
| { | ||
| $(".add-document").show(); |
There was a problem hiding this comment.
This is not really a 'Vue' way of doing it. Use v-show instead
| loadModelEvidencio() { | ||
| var self = this; | ||
|
|
||
| $.ajax({ |
There was a problem hiding this comment.
You might want to use axios for better ajax requests. You can also add the CSRF token by default, so that you do not have to add it manually all the time.
There was a problem hiding this comment.
Axios is nice indeed, works well with Vue. I am still starting with it though (yesterday, actually), so I still haven't quite figured out how it deals with multiple AJAX requests with one final callback.
|
|
||
| @section('content') | ||
|
|
||
| {{ _("Dear")}} {{$user->first_name}},<br> |
There was a problem hiding this comment.
This should be one call to _. Some languages will start with the name instead of 'Dear'.
| <th width="5%"></th> | ||
| <th width="5%"></th> | ||
| <th width="5%"></th> | ||
| <th width="4%"></th> |
There was a problem hiding this comment.
You might want to make this dynamic
routes/web.php
Outdated
| Route::get('/usersverification', 'UsersVerificationController@index')->name('usersverification.index'); | ||
|
|
||
| Route::get('/usersverification/download/{id}', 'UsersVerificationController@download')->name('usersverification.download'); | ||
| Route::post('/usersverification/accept', 'UsersVerificationController@accept')->name('usersverification.accept'); |
There was a problem hiding this comment.
It's best if you split the route file up in multiple files such that each file belongs to a single entity.
Will now see if I can move functions from controllers to models
Has to be tested thouroughly, so I would appreciate the help
Rest team final PR fixes
To do: Fontawesome
Hope I found all the icons used
Designer pr fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the designer and added missing options; implemented saving of workflows; connected patient side to the database; improved charts; improved PDF output; implemented "my workflows" page; improved registration and authorisation.