Enforce license headers #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NB: The email for the owner was taken from the information of the 'sdl' github account, it
probably should be changed to an alias such as "opensource@sdl.com".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a license on the main project is important, but to avoid issues when people just copy out files a brief license template should be applied to source files as well.
This PR just uses the maven license plugin to enforce a basic header, but I think this needs some work:
Potentially it might make sense to use a custom template to avoid at least the email issue, but check the Apache license FAQ first!
(Disclaimer: IANAL.)
FWIW: when the plugin complains about missing headers, you can quickly update them by running
mvn license:format.