Issue/36 dag configuration translator #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AG-configuration-translator
|
We need to add an API route to be able to add a selected entrypoint to an block which is already added to a project. The DAG translator needs the block to have a selected entrypoint, but up to now we cannot add this after a block was added to a project. |
PaulKalho
requested changes
Jan 21, 2025
Comment on lines
1
to
30
| """changes to project and block | ||
|
|
||
| Revision ID: d96594e39ae6 | ||
| Revises: 449a1635be99 | ||
| Create Date: 2025-01-08 02:05:50.343521 | ||
|
|
||
| """ | ||
| from typing import Sequence, Union | ||
|
|
||
| from alembic import op | ||
| import sqlalchemy as sa | ||
|
|
||
|
|
||
| # revision identifiers, used by Alembic. | ||
| revision: str = 'd96594e39ae6' | ||
| down_revision: Union[str, None] = '449a1635be99' | ||
| branch_labels: Union[str, Sequence[str], None] = None | ||
| depends_on: Union[str, Sequence[str], None] = None | ||
|
|
||
|
|
||
| def upgrade() -> None: | ||
| # ### commands auto generated by Alembic - please adjust! ### | ||
| pass | ||
| # ### end Alembic commands ### | ||
|
|
||
|
|
||
| def downgrade() -> None: | ||
| # ### commands auto generated by Alembic - please adjust! ### | ||
| pass | ||
| # ### end Alembic commands ### |
There was a problem hiding this comment.
Let's look into the migrations together as soon as I find some time
| try: | ||
| project_uuid = project_controller.create_project( | ||
| data.name, | ||
| token_data.get("user_uuid") | ||
| data.name, data.user_uuid |
There was a problem hiding this comment.
Why not extracting the user_uuid from the token?
Comment on lines
84
to
104
| async def add_new_block(data: AddNewBlockRequest): | ||
| try: | ||
| project_controller.add_new_block( | ||
| data.project_uuid, | ||
| data.name, | ||
| data.priority_weight, | ||
| data.retries, | ||
| data.retry_delay, | ||
| data.custom_name, | ||
| data.description, | ||
| data.author, | ||
| data.docker_image, | ||
| data.repo_url, | ||
| # data.selected_entrypoint_uuid, | ||
| data.x_pos, | ||
| data.y_pos, | ||
| data.upstream_blocks, | ||
| data.downstream_blocks | ||
| ) | ||
| except Exception as e: | ||
| raise handle_error(e) |
There was a problem hiding this comment.
As already written in the corresponding controller function & discussed on Slack. I suppose we do not need this endpoint. Do you agree? Or am I missing some use-cases here?
Co-authored-by: Paul Kalhorn <67231903+PaulKalho@users.noreply.github.com>
Co-authored-by: Paul Kalhorn <67231903+PaulKalho@users.noreply.github.com>
Co-authored-by: Paul Kalhorn <67231903+PaulKalho@users.noreply.github.com>
…TH-TIME/scystream into issue/36-DAG-configuration-translator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts our project and block model into a python file for airflow.
Also validates the DAG to be acyclic.