Enhanced commitAddObject to allow disabling AUTOPORTS creation#154
Open
bpothier wants to merge 3 commits intoRackTables:maintenance-0.20.xfrom
Open
Enhanced commitAddObject to allow disabling AUTOPORTS creation#154bpothier wants to merge 3 commits intoRackTables:maintenance-0.20.xfrom
bpothier wants to merge 3 commits intoRackTables:maintenance-0.20.xfrom
Conversation
Added (optional) 6th parameter to commitAddObject to disable calling the executeAutoPorts logic (e.g. kvm, eth0, eth1) Initially intended for UCS population where specific ports are defined at object creation time
Added checkbox to renderEditUCSForm() that defaults to on/checked/TRUE to disable creating the AUTOPORTS (e.g. kvm, eth0, eth1)
Added logic to call commitAddObject with (optional) 6th parameter to disable calling executeAutoPorts during object creation. This disables ccreating the default AUTOPORTS (e.g. kvm, eth0, eth1) since this function will populate each server with the actual ports configured on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added optional 6th parameter to commitAddObject to allow disabling calling the executeAutoPorts function which creates the AUTOPORTS (e.g. kvm, eth0, eth1)
Initially this will be used by the autoPopulateUCS function, since it will populate each server object with the actual ports defined