fix VLANSwitch table for mysql 5.7#172
Open
github138 wants to merge 1 commit intoRackTables:maintenance-0.20.xfrom
Open
fix VLANSwitch table for mysql 5.7#172github138 wants to merge 1 commit intoRackTables:maintenance-0.20.xfrom
github138 wants to merge 1 commit intoRackTables:maintenance-0.20.xfrom
Conversation
* remove workaround 0c53bc4
Member
|
The fix to this problem does include the table changes but it also must include a thorough review of the SQL queries and the PHP code that use the table to make sure everything works as before. Commit 8ea0abc was an easy example of such change. I started to verify the changes to |
Member
|
We can get back to this after PR #158 if you want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix VLANSwitch table creation with mysql 5.7 and NO_ZERO_DATE enabled (default).
Install works.
Upgrade needs testing because i don't use this feature and have no data!!