more ubiquiti and sharing sysObjectID between devices#185
Open
gottaloveit wants to merge 5 commits intoRackTables:maintenance-0.20.xfrom
Open
more ubiquiti and sharing sysObjectID between devices#185gottaloveit wants to merge 5 commits intoRackTables:maintenance-0.20.xfrom
gottaloveit wants to merge 5 commits intoRackTables:maintenance-0.20.xfrom
Conversation
adding ES-16-XG 10gb switch
due to sysdescr oid being the same
for case when multiple different models share same sysdescr
Member
|
Some obvious cleanups are due, but other than that maybe @adoom42 has an opinion about the proposed change? |
Member
|
It looks like a novel approach which adds support for new models without affecting any existing ones. Once the code is adjusted for style/formatting standards, I'd merge it. |
Member
|
It may be simpler to keep the vendor-specific files as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think I committed my previous PR #184 too soon.
I just got a different model Ubiquiti switch and noticed they have the same sysObjectID.
So I hacked up the code a bit and added what I think could work in this situation for any manufacturer. I do know that I tried to make it manufacturer agnostic and the code does work fine.