-
Notifications
You must be signed in to change notification settings - Fork 42
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
10 changed files
with
47 additions
and
111 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
2.5.1 | ||
2.6.beta-1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
import os | ||
|
||
__version__ = '2.5.1' | ||
__version__ = '2.6.beta-1' | ||
|
||
|
||
def _get_version(): | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,12 @@ | ||
Changelog | ||
========= | ||
|
||
2.6.beta1 | ||
--------- | ||
|
||
- Add subscription feature. | ||
- Send email notifications. | ||
|
||
2.5.1 | ||
------ | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,105 +1 @@ | ||
Contributing | ||
============= | ||
|
||
Django Comments Dab is developed and maintained by developers in an Open Source manner. | ||
Any support is welcome. You could help by writing documentation, pull-requests, report issues and/or translations. | ||
|
||
PR and commit messages | ||
^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
**Pull Requests** | ||
|
||
Refer to `#125`_ | ||
|
||
.. _`#125`: https://github.com/Radi85/Comment/discussions/125 | ||
|
||
In order to keep master clean and up to date with the current release, all PR shall be merged with ``develop-RELEASE_MILESTONE`` branch. | ||
|
||
``RELEASE_MILESTONE`` should be milestone tag of the issue you work on. | ||
|
||
**Commit messages** | ||
|
||
Use one commit per issue and try to keep the first line within 50 characters. | ||
|
||
Need more? use the commit body. | ||
|
||
The commit message should reference the issue number in the header (first line) like so: | ||
|
||
feat(*#NUMBER*): YOUR COMMIT | ||
|
||
**headers:** | ||
|
||
- feat(*#NUMBER*) for adding new feature | ||
- fix(*#NUMBER*) for fixing a bug | ||
- ref(*#NUMBER*) for code refactoring and enhancement | ||
- test(*#NUMBER*) for adding, fixing or adjusting tests | ||
- doc(*#NUMBER*) for documentation | ||
|
||
The issue number can be skipped if not available. | ||
|
||
Development | ||
^^^^^^^^^^^ | ||
|
||
To start development on this project, fork_ this repository and follow the guidelines given below. | ||
|
||
.. _fork: https://docs.github.com/en/free-pro-team@latest/github/getting-started-with-github/fork-a-repo | ||
|
||
.. code:: bash | ||
# clone the forked repository | ||
$ git clone YOUR_FORKED_REPO_URL | ||
# create a virtual environment | ||
$ python3 -m venv local_env | ||
# activate the virtual environment | ||
$ source local_env/bin/activate | ||
# install dependencies | ||
(venv) $ pip install -e . -r example/requirements.txt | ||
(venv) $ export DEBUG="True" | ||
# migrate the changes to database | ||
(venv) $ python manage.py migrate | ||
# prepare initial data | ||
(venv) $ python manage.py create_initial_data | ||
# start the development server | ||
(venv) $ python manage.py runserver | ||
Or run with docker | ||
|
||
.. code:: bash | ||
$ git clone YOUR_FORKED_REPO_URL | ||
$ cd Comment | ||
$ docker-compose up | ||
Login with: | ||
|
||
username: ``test`` | ||
|
||
password: ``test`` | ||
|
||
Testing | ||
^^^^^^^ | ||
|
||
To run tests against a particular ``python`` and ``django`` version installed inside your virtual environment, you may use: | ||
|
||
.. code:: bash | ||
(venv) $ python manage.py test | ||
To run tests against all supported ``python`` and ``django`` versions, you may run: | ||
|
||
.. code:: bash | ||
# install dependency | ||
(venv) $ pip install tox | ||
# run tests | ||
(venv) $ tox | ||
Translations | ||
^^^^^^^^^^^^ | ||
|
||
To add translations in your native language, please take a look at the :ref:`instructions for translators<Adding Support for Translation>`. | ||
.. include:: ../../CONTRIBUTING.rst |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
=============== | ||
Release Notes | ||
=============== | ||
|
||
.. toctree:: | ||
:maxdepth: 0 | ||
|
||
version-2.6 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
========================= | ||
Django-comments-dab v2.6 | ||
========================= | ||
|
||
v2.6.beta-1 | ||
------------ | ||
|
||
Features | ||
^^^^^^^^^ | ||
|
||
- `#43`_ - Add thread (content-type and parent comment) subscription. | ||
- `#43`_ - Send email notification to thread's subscribers on creating new comment. | ||
|
||
.. _#43: https://github.com/Radi85/Comment/issues/43 | ||
|
||
Codebase enhancement | ||
^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
- `#112`_ - Reduce testing time in pipeline. | ||
- `#122`_ - Code clean up. | ||
- `#129`_ - Update development guideline. | ||
|
||
.. _#112: https://github.com/Radi85/Comment/issues/112 | ||
.. _#122: https://github.com/Radi85/Comment/issues/43 | ||
.. _#129: https://github.com/Radi85/Comment/issues/43 |