Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add x-amz-security-token header #32

Merged

Conversation

JeffersonCurveBeam
Copy link

@JeffersonCurveBeam JeffersonCurveBeam commented Jan 17, 2024

Addressing #28

PR by @Kevinwochan #31 enables optional sessionToken authentication credential. Requests signed using temporary credentials requires an extra request header - x-amz-security-token

Tested this PR for both long-term credential (accessKeyId + secretAccessKey) and temporary credential (accessKeyId + secretAccessKey + sessionToken) authentication flows.

Copy link
Collaborator

@IbrahimCSAE IbrahimCSAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IbrahimCSAE IbrahimCSAE merged commit 0851a07 into RadicalImaging:master Jan 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants