Skip to content

update(station_factory): imt ue & bs antenna deduplication#216

Merged
brunohcfaria merged 2 commits intodevelopmentfrom
update/deduplicating_unnecessary_antennas
Sep 4, 2025
Merged

update(station_factory): imt ue & bs antenna deduplication#216
brunohcfaria merged 2 commits intodevelopmentfrom
update/deduplicating_unnecessary_antennas

Conversation

@artistrea
Copy link
Member

After the previous PRs #214 and #215 , using a different file, with P.619 and using imt.ue.antenna.pattern = OMNI instead of ARRAY. In the first ten drops, the total time taken was 28.6 seconds, 1/3 of which because of antenna creation:

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
   130744    0.210    0.000   11.909    0.000 antenna_factory.py:21(create_antenna)
       10    1.407    0.141   10.252    1.025 station_factory.py:70(generate_imt_base_stations)
    65367    0.709    0.000    7.321    0.000 antenna_s1528.py:27(__init__)

Using this PR speeds up the simulation considerably.

@brunohcfaria
Copy link

Please, fix lint errors.

@artistrea artistrea force-pushed the update/deduplicating_unnecessary_antennas branch from 7db9d4e to f188dc7 Compare September 3, 2025 17:23
@artistrea artistrea force-pushed the update/deduplicating_unnecessary_antennas branch from f188dc7 to 1afde69 Compare September 3, 2025 17:31
@brunohcfaria brunohcfaria merged commit e48d0e8 into development Sep 4, 2025
2 checks passed
@brunohcfaria brunohcfaria deleted the update/deduplicating_unnecessary_antennas branch September 4, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants