update(station_factory): imt ue & bs antenna deduplication#216
Merged
brunohcfaria merged 2 commits intodevelopmentfrom Sep 4, 2025
Merged
update(station_factory): imt ue & bs antenna deduplication#216brunohcfaria merged 2 commits intodevelopmentfrom
brunohcfaria merged 2 commits intodevelopmentfrom
Conversation
brunohcfaria
requested changes
Sep 3, 2025
|
Please, fix lint errors. |
7db9d4e to
f188dc7
Compare
f188dc7 to
1afde69
Compare
brunohcfaria
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the previous PRs #214 and #215 , using a different file, with P.619 and using imt.ue.antenna.pattern =
OMNIinstead ofARRAY. In the first ten drops, the total time taken was 28.6 seconds, 1/3 of which because of antenna creation:Using this PR speeds up the simulation considerably.