Draft
Conversation
* It's a simple mask where the user defines the mask steps across adjacent bands.
* Added a new oob_antenna into StationManager that represents the oob antenna pattern to be used for oob emission interference calculations. * WIP: for now only IMT and MSS_D2D stations has this.
calculating SYS to IMT coupling loss.
gain to the results.
antenna pattern. * The frequency factor should embedded into the Stepped Mask not to the antenna.
the station factory methods.
artistrea
requested changes
Nov 28, 2025
Comment on lines
570
to
575
| # FIXME: for more than 1 sys | ||
| # NOTE: sharc impl already doesn't really work with n_sys > 1 | ||
| # so more would have to be fixed before this | ||
| # assert np.all(adj_loss == adj_loss.flat[0]) | ||
|
|
||
| tx_oob_s = tx_oob - adj_loss[0, :] |
Member
There was a problem hiding this comment.
If the code keeps indexing the zero-th index, adj_loss[0, :], the assert np.all(adj_loss == adj_loss.flat[0]) should be maintained to confirm expected behavior is happening
Author
There was a problem hiding this comment.
It wasn't intentional... I'll revert it back
BTW, exceptions are better for this purpose.
coupling loss calcultion for inband/oob emission cases.
brunohcfaria
force-pushed
the
exp/oob_antenna_pattern
branch
from
4ada35c to
81ddf81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for out-of-band antenna pattern.
This is useful for adjacent (or co-channel with OOBE) studies where the OOB antenna has a different diagram than the in-band antenna. This case usually happens when the in-band antenna is an array model where the OOB antenna pattern is equal to the single-element pattern of the array.