Skip to content

Commit

Permalink
Fix a minor rebase bug
Browse files Browse the repository at this point in the history
  • Loading branch information
bhazelton committed Oct 16, 2024
1 parent de77a82 commit c2aba45
Showing 1 changed file with 2 additions and 15 deletions.
17 changes: 2 additions & 15 deletions src/pyuvdata/uvbeam/uvbeam.py
Original file line number Diff line number Diff line change
Expand Up @@ -4316,23 +4316,10 @@ def read_feko_beam(
if not isinstance(filename, (list, tuple)) and filename.endswith("yaml"):

Check warning on line 4316 in src/pyuvdata/uvbeam/uvbeam.py

View check run for this annotation

Codecov / codecov/patch

src/pyuvdata/uvbeam/uvbeam.py#L4316

Added line #L4316 was not covered by tests
# update filelist
basename = os.path.basename(filename)
self.filename = uvutils._combine_filenames(self.filename, [basename])
self.filename = utils._combine_filenames(self.filename, [basename])
self._filename.form = (len(self.filename),)

Check warning on line 4320 in src/pyuvdata/uvbeam/uvbeam.py

View check run for this annotation

Codecov / codecov/patch

src/pyuvdata/uvbeam/uvbeam.py#L4318-L4320

Added lines #L4318 - L4320 were not covered by tests

def read_mwa_beam(
self,
h5filepath,
use_future_array_shapes=False,
delays=None,
amplitudes=None,
pixels_per_deg=5,
freq_range=None,
run_check=True,
check_extra=True,
run_check_acceptability=True,
check_auto_power=True,
fix_auto_power=True,
):
def read_mwa_beam(self, h5filepath, **kwargs):
"""
Read in the full embedded element MWA beam.
Expand Down

1 comment on commit c2aba45

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: c2aba45 Previous: 72dd3bc Ratio
tests/utils/test_bls.py::test_bls_to_ant[min=65536-len=1000] 16113.145128106 iter/sec (stddev: 0.0009238038735587226) 33672.05686613388 iter/sec (stddev: 0.000012705208926630871) 2.09
tests/utils/test_bls.py::test_bls_to_ant[min=4259840-len=1000000] 51.20142946407967 iter/sec (stddev: 0.02206583791694618) 109.88722109678109 iter/sec (stddev: 0.0006359784156839246) 2.15
tests/utils/test_bls.py::test_ants_to_bls[min=0-len=1000000] 11.212501062384634 iter/sec (stddev: 0.07491930101289816) 25.39529318728484 iter/sec (stddev: 0.0051326475372339125) 2.26
tests/utils/test_bls.py::test_ants_to_bls[min=65536-len=1] 7304.804265048118 iter/sec (stddev: 0.00030107825041631847) 19018.809758528256 iter/sec (stddev: 0.000020634598156091437) 2.60
tests/utils/test_bls.py::test_ants_to_bls[min=65536-len=10000] 957.3435999205858 iter/sec (stddev: 0.007144314675189152) 2626.1443811390286 iter/sec (stddev: 0.00004557742609505649) 2.74

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.