Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in calc_app_coords #1325

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Fix bug in calc_app_coords #1325

merged 3 commits into from
Jul 28, 2023

Conversation

kartographer
Copy link
Contributor

Description

A bug in utils.calc_app_coords caused Time objects to not be handled correctly when supplied as the argument for the time_array keyword. At issue was the underlying equality-checking of the Time class (and it's returning False when compared against number types, even when the numeric value appears to be identical).

Motivation and Context

I am motivated to fix bugs in my code.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Bug fix checklist:

  • My fix includes a new test that breaks as a result of the bug (if possible).
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (11b8ea5) to head (e3fb7f7).
Report is 659 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1325   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          36       36           
  Lines       19935    19938    +3     
=======================================
+ Hits        19919    19922    +3     
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kartographer !

@steven-murray steven-murray merged commit 555f793 into main Jul 28, 2023
39 of 43 checks passed
@steven-murray steven-murray deleted the calc_app_coords_fix branch July 28, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants