Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A bug in
utils.calc_app_coords
caused Time objects to not be handled correctly when supplied as the argument for thetime_array
keyword. At issue was the underlying equality-checking of the Time class (and it's returningFalse
when compared against number types, even when the numeric value appears to be identical).Motivation and Context
I am motivated to fix bugs in my code.
Types of changes
Checklist:
Bug fix checklist: