Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CalH5 file format #1362

Merged
merged 12 commits into from
Mar 27, 2024
Merged

Add CalH5 file format #1362

merged 12 commits into from
Mar 27, 2024

Conversation

bhazelton
Copy link
Member

@bhazelton bhazelton commented Dec 2, 2023

Description

Add support for a new HDF5 based UVCal file format, with partial read support.

This includes significant refactoring to allow code to be reused, including:

  • Refactoring the select method on UVCal (along the lines of the refactored UVData select).
  • Refactoring a lot of the HDF5 code from uvh5.py into a new hdf5_utils.py file at the top level.
  • Refactoring time selection logic from UVData, moving it into utils.py.

Motivation and Context

addresses #876

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

New feature checklist:

  • I have added or updated the docstrings associated with my feature using the numpy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate).
  • I have added tests to cover my new feature.
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (05f6a0c) to head (07d9f7a).

Additional details and impacted files
@@             Coverage Diff             @@
##           prep_v3.0    #1362    +/-   ##
===========================================
  Coverage      99.92%   99.92%            
===========================================
  Files             37       39     +2     
  Lines          21093    21488   +395     
===========================================
+ Hits           21077    21472   +395     
  Misses            16       16            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kartographer kartographer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhazelton -- finally got a chance to look through everything following having had a chance to play around with things. Mostly very minor comments and some questions that may be more a reflection of my lack of prior experience w/ UVCal (always more to learn 😄 ).

pyuvdata/hdf5_utils.py Outdated Show resolved Hide resolved
pyuvdata/hdf5_utils.py Show resolved Hide resolved
pyuvdata/uvcal/tests/__init__.py Outdated Show resolved Hide resolved
pyuvdata/uvcal/tests/conftest.py Show resolved Hide resolved
pyuvdata/uvcal/uvcal.py Outdated Show resolved Hide resolved
pyuvdata/uvcal/uvcal.py Show resolved Hide resolved
pyuvdata/uvcal/uvcal.py Show resolved Hide resolved
pyuvdata/uvcal/calh5.py Outdated Show resolved Hide resolved
pyuvdata/uvcal/calh5.py Show resolved Hide resolved
pyuvdata/uvcal/calh5.py Show resolved Hide resolved
@bhazelton
Copy link
Member Author

Tests are breaking because they're picking up the new version of lunarsky. They'll be fixed when we merge #1417 and rebase.

Copy link
Contributor

@kartographer kartographer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @bhazelton!

@bhazelton bhazelton merged commit 8355244 into prep_v3.0 Mar 27, 2024
41 of 44 checks passed
@bhazelton bhazelton deleted the calh5 branch March 27, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Calibration enhancement HERA Things needed to support HERA development.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants