-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CalH5 file format #1362
Add CalH5 file format #1362
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## prep_v3.0 #1362 +/- ##
===========================================
Coverage 99.92% 99.92%
===========================================
Files 37 39 +2
Lines 21093 21488 +395
===========================================
+ Hits 21077 21472 +395
Misses 16 16 ☔ View full report in Codecov by Sentry. |
8efda88
to
0e57b9c
Compare
3be3a14
to
b3626d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bhazelton -- finally got a chance to look through everything following having had a chance to play around with things. Mostly very minor comments and some questions that may be more a reflection of my lack of prior experience w/ UVCal (always more to learn 😄 ).
2d25065
to
f630da3
Compare
Tests are breaking because they're picking up the new version of lunarsky. They'll be fixed when we merge #1417 and rebase. |
Also fix error message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @bhazelton!
Description
Add support for a new HDF5 based UVCal file format, with partial read support.
This includes significant refactoring to allow code to be reused, including:
uvh5.py
into a newhdf5_utils.py
file at the top level.utils.py
.Motivation and Context
addresses #876
Types of changes
Checklist:
New feature checklist: