Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug fix for tests.WarningChecker when IERS is down #1382

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

kartographer
Copy link
Contributor

Fixes testing bug.

Description

I've updated the WarningChecker class inside of pyuvdata.tests to handle when the IERS service is down and when check_warnings is being called with the expected warning and text match being set to None (which effectively ensures that no warnings are being thrown).

Motivation and Context

There are about half a dozen tests which use check_warnings to make sure no warnings are being thrown, which were failing due to the previously uncaught behavior. This sems to be a fairly rare occurence that's popped up recently due to what appear to be IERS server issues.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Bug fix checklist:

  • My fix includes a new test that breaks as a result of the bug (if possible).
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb99885) 99.92% compared to head (c67a546) 99.92%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1382   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          37       37           
  Lines       20423    20423           
=======================================
  Hits        20407    20407           
  Misses         16       16           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb99885...c67a546. Read the comment docs.

@kartographer
Copy link
Contributor Author

Note that this seems to be a different error from the one impacting the warnings ci. This problem was causing intermittent failures on the other pipelines.

Copy link
Member

@bhazelton bhazelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Thanks!

@bhazelton bhazelton merged commit 4293cca into main Jan 24, 2024
53 checks passed
@bhazelton bhazelton deleted the iers_warn_none_match_fix branch January 24, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants