Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fix: Mambaforge is deprecated and mamba in now the default installer #1478

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

bhazelton
Copy link
Member

@bhazelton bhazelton commented Sep 18, 2024

Description

Fixes deprecation warnings on GitHub actions runs about mambaforge going away. Mambaforge and Miniforge are now identical and mamba is the used by default in conda. See https://conda-forge.org/news/2024/07/29/sunsetting-mambaforge/

Motivation and Context

Fixes #1477

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

Build or continuous integration change checklist:

  • If required or optional dependencies have changed (including version numbers), I have updated the readme to reflect this.
  • If this is a new CI setup, I have added the associated badge to the readme and to references/make_index.py (if appropriate).

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (c80821e) to head (15b7e55).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1478   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          61       61           
  Lines       21337    21337           
=======================================
  Hits        21322    21322           
  Misses         15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mkolopanis mkolopanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good to me, should we mark this to close #1477 as well?

@bhazelton
Copy link
Member Author

looks pretty good to me, should we mark this to close #1477 as well?

Ha! I hadn't seen that issue. I'll mark this to close it.

@mkolopanis mkolopanis merged commit f126a9a into main Sep 19, 2024
46 checks passed
@mkolopanis mkolopanis deleted the fix_ci_warnings branch September 19, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Mambaforge calls from CI
2 participants