Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: do a full warmup run to reduce variance on first benchmark run #14

Merged
merged 6 commits into from
Oct 15, 2024

Conversation

RafaelGSS
Copy link
Owner

Fixes: #12

@RafaelGSS
Copy link
Owner Author

Before this fix:

test at test/env.js:12:3
✖ must have a similar benchmark result (0.88ms)
  AssertionError [ERR_ASSERTION]: 213241088.30334634 too different from 129032871.41930455 - Using includes
      at TestContext.<anonymous> (/Users/rafaelgss/repos/os/bench-node/test/env.js:24:18)
      at Test.runInAsyncScope (node:async_hooks:211:14)
      at Test.run (node:internal/test_runner/test:930:25)
      at async Promise.all (index 0)
      at async Suite.run (node:internal/test_runner/test:1295:7)
      at async startSubtestAfterBootstrap (node:internal/test_runner/harness:289:3) {
    generatedMessage: false,
    code: 'ERR_ASSERTION',
    actual: false,
    expected: true,
    operator: '=='
  }

@RafaelGSS RafaelGSS merged commit fa57188 into main Oct 15, 2024
3 checks passed
@RafaelGSS RafaelGSS deleted the fix-copied-results branch October 15, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistencies on copied results
2 participants