Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add benchmark repetition #27

Merged

Conversation

gusanthiago
Copy link
Contributor

@gusanthiago gusanthiago commented Dec 10, 2024

Hello there, this is related to this issue #6.

This PR aims to introduce benchmark repetition as an optional parameter. By running benchmarks multiple times and averaging the results, we can minimize noise and improve the accuracy of the measurements.

Below, you’ll find a comparison of benchmarks with repetition versus those without:

 node --allow-natives-syntax examples/create-uint32array/node.js
Screenshot 2024-12-10 at 01 04 36

Let me know if need add something, thanks :)

Copy link
Owner

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for the PR

I'd just rename the "repetitions" to "repeatSuite". We run the benchmark multiple times already (benchmark runs * samples) and adding an option with that name would be misleading.

@RafaelGSS
Copy link
Owner

Could you also update the docs?

@gusanthiago
Copy link
Contributor Author

Sure @RafaelGSS , I believe makes sense, I gonna update the docs and rename it

Copy link
Owner

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelGSS RafaelGSS merged commit d65e8aa into RafaelGSS:main Dec 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants