feat: add memory-spike plugin #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafaelGSS
reviewed
Dec 27, 2024
There was a problem hiding this comment.
Instead of creating a function inside globalThis, I'd add all the context into the beforeClockTemplate. Also, I wouldn't perform memory translations during the collect process, instead, you can do it textReporter. Just check if bench.plugins includes this new plugin.
| #spikeSamples = {}; | ||
| isSupported() { | ||
| try { | ||
| new Function(`gc()`); |
There was a problem hiding this comment.
Suggested change
| new Function(`gc()`); | |
| new Function(`gc()`)(); |
I think you should call the function to it to throw, right?
Comment on lines
+100
to
+103
| getReport() { | ||
| process._rawDebug('grp',arguments); | ||
|
|
||
| } |
There was a problem hiding this comment.
This shouldn't be here, right?
|
|
||
| ### Class: `RecordMemorySpikePlugin` | ||
|
|
||
| A plugin to record memory allocation spikes in your benchmark's run. It should help you understand the speed vs memory tradeoffs you're making. |
There was a problem hiding this comment.
We should mention folks that are going to use it will need to pass --expose-gc
There was a problem hiding this comment.
I'd also mention a possible performance inconsistency when this plugin is enabled due to GC blocking op.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it took going on holiday again, but here it is
open questions:
__recordMemorySpikegoing to cause trouble in workers?