Skip to content

Commit

Permalink
code rev
Browse files Browse the repository at this point in the history
  • Loading branch information
Raffaello committed Sep 30, 2023
1 parent 3cad67d commit 193bb43
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,8 @@

namespace HyperSonicDrivers::drivers::midi::opl
{

OplChannel::OplChannel(const uint8_t channel)
: IMidiChannel(channel)
{
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ namespace HyperSonicDrivers::drivers::midi::opl
class OplChannel : public IMidiChannel
{
public:
OplChannel() = default;
OplChannel(const uint8_t channel);

Check notice on line 10 in sdl2-hyper-sonic-drivers/src/HyperSonicDrivers/drivers/midi/opl/OplChannel.hpp

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

sdl2-hyper-sonic-drivers/src/HyperSonicDrivers/drivers/midi/opl/OplChannel.hpp#L10

Class 'OplChannel' has a constructor with 1 argument that is not explicit.
};
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#include <format>
#include <cassert>
#include <HyperSonicDrivers/drivers/midi/opl/OplDriver.hpp>
#include <HyperSonicDrivers/drivers/midi/opl/OplChannel.hpp>
#include <HyperSonicDrivers/hardware/opl/OplType.hpp>
#include <HyperSonicDrivers/utils/ILogger.hpp>

Expand Down Expand Up @@ -33,7 +34,7 @@ namespace HyperSonicDrivers::drivers::midi::opl
m_oplWriter = std::make_unique<drivers::opl::OplWriter>(m_opl, m_opl3_mode);

for (uint8_t i = 0; i < audio::midi::MIDI_MAX_CHANNELS; ++i) {
m_channels[i] = std::make_unique<IMidiChannel>(i);
m_channels[i] = std::make_unique<OplChannel>(i);
}

m_voices.resize(m_oplNumChannels);
Expand Down

0 comments on commit 193bb43

Please sign in to comment.