renderer max_channels | package test mocks #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raffaello
added
the
refactor
Raffaello
added
question
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure if renderer should have more than 1 channel, but could it be ok to rendering mixed audio?
because alternatively if needing more channels could create multiple render, but it won't mix up the audio, and that is still ok, as there will be 2 different audio files that can be mixed later on during playback and this will also give a better versatility....
not sure...
need to think about it a little first.
This give options and flexibility to use cases, so it is not bad, but not sure if it might just lead to wrong usage instead....