Skip to content

Conversation

@StephenHodgson
Copy link
Member

  • updated xcode version handling
  • refactored action to be more robust and reliable

- updated xcode version handling
- refactored action to be more robust and reliable
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Xcode version handling to be more robust and reliable, and includes a significant refactoring of the action architecture to improve maintainability and testing.

Key changes include:

  • Refactored Xcode version management with enhanced version detection and selection
  • Extracted shared utilities and improved error handling throughout the codebase
  • Updated CI/CD workflow structure with matrix-based testing and proper job separation

Reviewed Changes

Copilot reviewed 7 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/xcode.ts Major refactoring with new Xcode version handling, improved error handling, and code organization
src/utilities.ts Added new utility functions for file operations, path globbing, and deep equality checks
src/index.ts Simplified main function by extracting Xcode version logic to separate function
src/XcodeProject.ts Updated constructor parameter order and improved property initialization
package.json Version bump and dependency updates
.github/workflows/validate.yml Restructured workflow to use job matrix setup pattern
.github/workflows/build.yml New reusable workflow for build operations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@StephenHodgson StephenHodgson marked this pull request as ready for review September 15, 2025 21:13
@StephenHodgson StephenHodgson changed the title unity-xcode-builder@v1.3.4 unity-xcode-builder@v1.4.0 Sep 16, 2025
@StephenHodgson StephenHodgson deleted the development branch September 16, 2025 21:46
@StephenHodgson StephenHodgson restored the development branch September 16, 2025 21:47
@StephenHodgson StephenHodgson merged commit fb05ff7 into main Sep 17, 2025
104 of 111 checks passed
@StephenHodgson StephenHodgson deleted the development branch September 17, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant