Merge pull request #48 from Ragin-LundF/develop

Better output for matcher
Ragin-LundF · Feb 2, 2021 · 1ae70c3 · 1ae70c3
2 parents 2540632 + f441252
commit 1ae70c3
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+# Release 1.25.0
+
+Small bugfix release for proper mismatch messages of the matchers.
+
 # Release 1.24.0
 
 ## New features

diff --git a/gradle.properties b/gradle.properties
@@ -1,5 +1,5 @@
 group=com.ragin.bdd
-version=1.24.0
+version=1.25.0
 
 systemProp.sonar.host.url=https://sonarcloud.io/
 systemProp.sonar.organization=ragin-lundf-github

diff --git a/src/main/java/com/ragin/bdd/cucumber/matcher/ScenarioStateContextMatcher.java b/src/main/java/com/ragin/bdd/cucumber/matcher/ScenarioStateContextMatcher.java
@@ -11,17 +11,29 @@ public class ScenarioStateContextMatcher extends BaseMatcher<Object> implements
     private String parameter;
 
     @Override
-    public boolean matches(Object actual) {
-        String parameterFromContext = ScenarioStateContext.current().getScenarioContextMap().get(parameter);
-        String actualAsString = String.valueOf(actual);
+    public boolean matches(final Object actual) {
+        final String parameterFromContext = ScenarioStateContext.current().getScenarioContextMap().get(parameter);
+        final String actualAsString = String.valueOf(actual);
         return (actualAsString.equals(parameterFromContext));
     }
 
     @Override
-    public void describeTo(Description description) {
+    public void describeTo(final Description description) {
         description.appendText("The actual value is not equal to the parameter [" + parameter + "]");
     }
 
+    @Override
+    public void describeMismatch(final Object item, final Description description) {
+        description
+                .appendText("BDD Context value was [")
+                .appendValue(ScenarioStateContext.current().getScenarioContextMap().get(parameter))
+                .appendText("].")
+                .appendText(" JSON Value was [")
+                .appendValue(item)
+                .appendText("]");
+        super.describeMismatch(item, description);
+    }
+
     @Override
     public void setParameter(String parameter) {
         this.parameter = parameter;

diff --git a/src/main/java/com/ragin/bdd/cucumber/matcher/UUIDMatcher.java b/src/main/java/com/ragin/bdd/cucumber/matcher/UUIDMatcher.java
@@ -19,7 +19,7 @@ public boolean matches(Object item) {
 
     @Override
     public void describeMismatch(Object item, Description description) {
-        description.appendText("Is not a valid date: ").appendValue(item);
+        description.appendText("Is not a valid UUID: ").appendValue(item);
     }
 
     @Override