Attiny828 fixes #232
Merged
Attiny828 fixes #232
+381
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rahix
reviewed
Dec 7, 2025
| <bitfield caption="USART Data Register Empty" mask="0x20" name="UDRE" rw="R"/> | ||
| <bitfield caption="Framing Error" mask="0x10" name="FE" rw="R"/> | ||
| <bitfield caption="Data Overrun" mask="0x08" name="DOR" rw="R"/> | ||
| <bitfield caption="Parity Error" mask="0x04" name="UPE" rw="R"/> |
Owner
There was a problem hiding this comment.
Just for my understanding, this was an update published by Microchip?
Contributor
Author
There was a problem hiding this comment.
Yep. Just downloaded a fresh pack via Mplab X IDE. These changes were there.
Should I revert them?
To be honest, I haven't tested USART with this MCU yet.
Owner
There was a problem hiding this comment.
No, totally fine as it is :)
Just wanted to make sure these changes really came from upstream. The ATDFs should not be modified locally in this project, we want to mirror whatever gets released by the vendor.
Rahix
approved these changes
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply fixes required after recent changes.
ATDF file was refreshed as well.
And I also found that step 8 in the README.md is no longer required since there is no table there any more.