Open
Conversation
Tweak the release profile to keep overflow-checks enabled. The performance hit is minimal and this ensures no bugs slip through. Additionally switch to panic=abort as we have no use for unwinding.
`.write()` may no actually write all data at once. Use `.write_all()` instead which has the expected behavior.
`as` conversions silently truncate values. Catch errors here and properly propagate them upwards
Makes it more obvious where error handling isn't great yet.
Properly bubble up errors during serial port discovery to the user.
Update the console handling code so both errors in the transmission and receival side are properly caught and lead to program termination.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various cleanups and improvements to the ravedude codebase. See commits for details.
Still needs testing.