Add /api/client/{clientId} Endpoint #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This endpoint returns general information about the client ID provided.
|
XUID please :) |
Updated `ClientInfoResult` to include a new `GameName` property. Also modified `ClientController` to handle and display this new property properly.
Ayymoss
force-pushed
the
feature/api-client-info
branch
from
13762fc
to
1a3076b
Compare
We've spoken about this in tester, it makes more sense to return the NetworkID explicitly than transform it into the hex string. |
RaidMax
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This endpoint returns general information about the client ID provided.
It might be worth leaving this PR open for a bit for other members to suggest additional data that should return on this endpoint.